-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PgValue variant bypassing QValue for more efficient & correct PG<>PG mirroring #1565
Conversation
Schema setup/changes needs to be corrected for PG<>PG & pulling in extra info like collation etc would be nice |
Problem: table schema deltas don't care about numeric precision/scale |
Problem: TypeModifier only used for numeric; should be used for all types such as |
can you share some examples where text representation of QValue differs from PGValue? |
This the wrong question, we could map everything to QValueInvalid, but that won't work for schema changes / creating correct matching tables That said, NaN/inf/-inf for doubles & numerics Similarly, we map json/jsonb both to QValueJSON, not preserving their difference Arrays are a whole thing |
230638e
to
182b242
Compare
Thoughts/listing things which can be done as followup:
|
92e7aa6
to
b65fbc9
Compare
102f116
to
e35ba7d
Compare
Currently enabled by passing
system = 'PG'
inCREATE MIRROR
command