Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerDB: For queues, move sync interval to advanced, default 10 mins #1672

Merged
merged 6 commits into from
May 6, 2024
Merged

PeerDB: For queues, move sync interval to advanced, default 10 mins #1672

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3dabf58
for queues, move sync interval to advanced, default 10 mins
Amogh-Bharadwaj May 6, 2024
6513efb
Merge branch 'main' into ui/queue-sync-interval
Amogh-Bharadwaj May 6, 2024
18804a0
improvements
Amogh-Bharadwaj May 6, 2024
fca9652
Merge branch 'main' into ui/queue-sync-interval
Amogh-Bharadwaj May 6, 2024
857626d
use enum
Amogh-Bharadwaj May 6, 2024
4e1feb1
Merge branch 'main' into ui/queue-sync-interval
Amogh-Bharadwaj May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 37 additions & 12 deletions ui/app/mirrors/create/cdc/cdc.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,37 @@ export default function CDCConfigForm({
};

const normalSettings = useMemo(() => {
return settings.filter((setting) => setting.advanced != true);
}, [settings]);
return settings!
.map((setting) => {
if (
IsQueuePeer(mirrorConfig.destination?.type) &&
setting.label === 'Sync Interval (Seconds)'
Amogh-Bharadwaj marked this conversation as resolved.
Show resolved Hide resolved
) {
return;
}
if (setting.advanced != true) {
return setting;
}
})
.filter((setting) => setting !== undefined);
Amogh-Bharadwaj marked this conversation as resolved.
Show resolved Hide resolved
}, [settings, mirrorConfig.destination?.type]);

const advancedSettings = useMemo(() => {
return settings.filter((setting) => setting.advanced == true);
}, [settings]);
return settings!
.map((setting) => {
if (
IsQueuePeer(mirrorConfig.destination?.type) &&
setting.label === 'Sync Interval (Seconds)'
) {
setting.stateHandler(600, setter);
return { ...setting, default: 600 };
}
if (setting.advanced == true) {
return setting;
}
})
.filter((setting) => setting !== undefined);
}, [settings, mirrorConfig.destination?.type, setter]);

const paramDisplayCondition = (setting: MirrorSetting) => {
const label = setting.label.toLowerCase();
Expand Down Expand Up @@ -91,15 +116,15 @@ export default function CDCConfigForm({
if (mirrorConfig.source != undefined && mirrorConfig.destination != undefined)
return (
<>
{normalSettings.map((setting, id) => {
{normalSettings!.map((setting, id) => {
return (
paramDisplayCondition(setting) && (
paramDisplayCondition(setting!) && (
<CDCField
key={id}
handleChange={handleChange}
setting={setting}
setting={setting!}
options={
setting.label === 'Publication Name'
setting?.label === 'Publication Name'
? publications
: undefined
}
Expand Down Expand Up @@ -128,13 +153,13 @@ export default function CDCConfigForm({
</Button>

{show &&
advancedSettings.map((setting, id) => {
advancedSettings!.map((setting, id) => {
return (
paramDisplayCondition(setting) && (
paramDisplayCondition(setting!) && (
<CDCField
key={setting.label}
key={setting?.label}
handleChange={handleChange}
setting={setting}
setting={setting!}
/>
)
);
Expand Down
Loading