initial load for queues #1675
Merged
initial load for queues #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
queues-initial-load
branch
3 times, most recently
from
c175ea0 to
4b0ccaf
Compare
iskakaushik
reviewed
May 7, 2024
iskakaushik
reviewed
May 7, 2024
iskakaushik
reviewed
May 7, 2024
| Loop: | ||
| for { | ||
| select { | ||
| case qrecord, ok := <-stream.Records: |
There was a problem hiding this comment.
seems like a lot of the code below is shared between pub-sub and Kafka, can we unify it?
There was a problem hiding this comment.
Also share quite a bit between cdc/qrep. It'll be a mess of conditions. Would be better as an isolated PR
iskakaushik
reviewed
May 7, 2024
| CommitID: 0, | ||
| } | ||
|
|
||
| lfn := ls.Env.RawGetString("onRecord") |
There was a problem hiding this comment.
doesn't cdc have to do something similar as well?
There was a problem hiding this comment.
Yes, but code is mixed up with tracking LSN/counts
|
makes sense, might be worth following up with a PR on cleaning some of this up :) |
iskakaushik
approved these changes
May 7, 2024
serprex
force-pushed
the
queues-initial-load
branch
from
6bfc8fe to
3badb8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out waitgroup unnecessary since kgo flush handles wait, so removed. Meanwhile, potential send-after-close found in pubsub, so fix
EventHubs is complicated, so skipped. Can be followup