Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch clickhouse SQL parsing #1676

Merged
merged 3 commits into from
May 6, 2024
Merged

Patch clickhouse SQL parsing #1676

merged 3 commits into from
May 6, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented May 6, 2024

Patches clickhouse peer creation from query layer

CREATE PEER <clickhouse_peer_name> FROM CLICKHOUSE
WITH
(
    host='<host>',
    port=<port>,
    user='<user>',
    password='<password>',
    database='<database>',
    -- disable_tls = true
);

Functionally tested:

amogh=> create peer mych from CLICKHOUSE with(host='host.docker.internal', port=9000, user='default', password='clickhouse', database='clickhouse', disable_tls = true);
OK
amogh=> create peer mych from CLICKHOUSE with(host='host.docker.internal', port=9000, user='default', password='clickhoufse', database='clickhouse', disable_tls = true);
ERROR:  User provided error: ErrorInfo { severity: "ERROR", code: "internal_error", message: "[peer]: invalid configuration: CLICKHOUSE peer mych was invalidated: failed to open connection to Clickhouse peer: failed to ping to Clickhouse peer: code: 516, message: default: Authentication failed: password is incorrect, or there is no user with such name.

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit e8ebd3c into main May 6, 2024
7 checks passed
@Amogh-Bharadwaj Amogh-Bharadwaj deleted the clickhouse-sql branch May 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants