BigQuery: Improve intermediate Avro methods #1679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
May 7, 2024
Comment on lines
+286
to
+288
| func GetAvroType(sourceField *qvalue.QField) (interface{}, error) { | ||
| avroNumericPrecision := int16(sourceField.Precision) | ||
| avroNumericScale := int16(sourceField.Scale) |
There was a problem hiding this comment.
Suggested change
| func GetAvroType(sourceField *qvalue.QField) (interface{}, error) { | |
| avroNumericPrecision := int16(sourceField.Precision) | |
| avroNumericScale := int16(sourceField.Scale) | |
| func GetAvroType(sourceField *qvalue.QField) (interface{}, error) { | |
| avroNumericPrecision := sourceField.Precision | |
| avroNumericScale := sourceField.Scale |
serprex
approved these changes
May 7, 2024
|
Does this fix any existing issues? |
No, but it allows for data type mapping configuration for bigquery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefineAvroSchemato now use the source schema instead of the target BigQuery table schema. This is consistent with Snowflake and Clickhouse, albeit not using the single method they both share - this is due to some type behaviour differences in BQ (Ex: timestamps).qValueKindToBigQueryType's return body to contain array (repeated) information, instead of relying on the assumption that source arrays are mapped to BQ arrays