Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wal heartbeat: allow overriding query with env variable #1725

Merged
merged 1 commit into from
May 27, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented May 15, 2024

To enable heartbeating, set these two environment vars:

  PEERDB_WAL_HEARTBEAT_QUERY: ${PEERDB_WAL_HEARTBEAT_QUERY:-UPDATE _peerdb_heartbeat SET last_heartbeat = now() WHERE id = 1;}
  PEERDB_ENABLE_WAL_HEARTBEAT: ${PEERDB_ENABLE_WAL_HEARTBEAT:-true}

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@serprex serprex requested a review from Amogh-Bharadwaj May 23, 2024 20:01
@Amogh-Bharadwaj
Copy link
Contributor

Should we also make the frequency of heartbeat an env ? @serprex @iskakaushik

@serprex
Copy link
Contributor Author

serprex commented May 24, 2024

I think that would be better as a later PR when needed, has to touch at temporal cron setup

@Amogh-Bharadwaj Amogh-Bharadwaj force-pushed the custom-wal-heartbeats branch from 3af9437 to 3d6268d Compare May 24, 2024 16:25
@Amogh-Bharadwaj
Copy link
Contributor

Functionally tested, updated description

@iskakaushik iskakaushik merged commit 3485158 into main May 27, 2024
6 of 7 checks passed
@iskakaushik iskakaushik deleted the custom-wal-heartbeats branch May 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants