Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close and recreate destination connections during syncflow when needed #1735

Merged
merged 8 commits into from
May 29, 2024
Merged

fix: close and recreate destination connections during syncflow when needed #1735

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b30da81
fix: close and recreate destination when needed
iamKunalGupta May 20, 2024
e19fd33
Merge branch 'main' into fix/recreate-destination-connector
Amogh-Bharadwaj May 23, 2024
b404aaa
move the dst connector retreival further down
Amogh-Bharadwaj May 24, 2024
9c13713
Merge branch 'main' into fix/recreate-destination-connector
serprex May 24, 2024
c23151e
Revert "move the dst connector retreival further down"
Amogh-Bharadwaj May 24, 2024
ef0aa22
Merge branch 'main' into fix/recreate-destination-connector
Amogh-Bharadwaj May 27, 2024
760949e
Merge branch 'main' into fix/recreate-destination-connector
iskakaushik May 28, 2024
6e1d068
Merge branch 'main' into fix/recreate-destination-connector
Amogh-Bharadwaj May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flow/activities/flowable_core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgxpool"
lua "github.com/yuin/gopher-lua"
"github.com/yuin/gopher-lua"
"go.temporal.io/sdk/activity"
"go.temporal.io/sdk/log"
"go.temporal.io/sdk/temporal"
Expand Down Expand Up @@ -143,6 +143,11 @@ func syncCore[TPull connectors.CDCPullConnectorCore, TSync connectors.CDCSyncCon
hasRecords := !recordBatch.WaitAndCheckEmpty()
logger.Info("current sync flow has records?", slog.Bool("hasRecords", hasRecords))

dstConn, err = connectors.GetAs[TSync](ctx, config.Destination)
if err != nil {
return nil, fmt.Errorf("failed to recreate destination connector: %w", err)
}

if !hasRecords {
// wait for the pull goroutine to finish
err = errGroup.Wait()
Expand All @@ -156,11 +161,6 @@ func syncCore[TPull connectors.CDCPullConnectorCore, TSync connectors.CDCSyncCon
}
logger.Info("no records to push")

dstConn, err = connectors.GetAs[TSync](ctx, config.Destination)
if err != nil {
return nil, fmt.Errorf("failed to recreate destination connector: %w", err)
}

err := dstConn.ReplayTableSchemaDeltas(ctx, flowName, recordBatch.SchemaDeltas)
if err != nil {
return nil, fmt.Errorf("failed to sync schema: %w", err)
Expand Down
Loading