Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable oneSync always #1755

Merged
merged 3 commits into from
May 27, 2024
Merged

Enable oneSync always #1755

merged 3 commits into from
May 27, 2024

Conversation

iskakaushik
Copy link
Contributor

This feature has been stabilized and no longer needs a disable flag.

@serprex
Copy link
Contributor

serprex commented May 26, 2024

In flowable_core.go you can remove SessionID == "" check

@@ -11,7 +11,7 @@ import (

"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgxpool"
"github.com/yuin/gopher-lua"
lua "github.com/yuin/gopher-lua"
Copy link
Contributor

@serprex serprex May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should fix your autoformat config settings to not do this, I think @Amogh-Bharadwaj turned this off recently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amogh-Bharadwaj can you share how you did this for my edification?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i spent a good 30 mins unable to figure this out. Landing as is as this is a minor thing.

@CLAassistant
Copy link

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

@iskakaushik iskakaushik merged commit 19ea9ea into main May 27, 2024
7 checks passed
@iskakaushik iskakaushik deleted the one-sync-always-on branch May 27, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants