Adds error reporting for CDC Mirror #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nexus/analyzer/src/lib.rs
Outdated
| } | ||
|
|
||
| fn stage_check(stage: String, peer_type: DbType)->Result<(), anyhow::Error>{ | ||
| if stage.len() > 0 && !stage.starts_with("s3://") && peer_type == DbType::Snowflake { |
There was a problem hiding this comment.
warning: length comparison to zero
--> analyzer/src/lib.rs:39:8
|
39 | if stage.len() > 0 && !stage.starts_with("s3://") && peer_type == DbType::Snowflake {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stage.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
nexus/analyzer/src/lib.rs
Outdated
| format!("{} {}", "cdc_staging_path", path_missing_err) | ||
| )); | ||
| } else if let Some(cdc_stage) = flow_job.cdc_staging_path.clone(){ | ||
| let _ = stage_check(cdc_stage, destination_peer_type)?; |
There was a problem hiding this comment.
warning: this let-binding has unit value
--> analyzer/src/lib.rs:85:13
|
85 | let _ = stage_check(cdc_stage, destination_peer_type)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `stage_check(cdc_stage, destination_peer_type)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
nexus/analyzer/src/lib.rs
Outdated
| } | ||
|
|
||
| fn stage_check(stage: String, peer_type: DbType) -> Result<(), anyhow::Error> { | ||
| if stage.len() > 0 && !stage.starts_with("s3://") && peer_type == DbType::Snowflake { |
There was a problem hiding this comment.
warning: length comparison to zero
--> analyzer/src/lib.rs:39:8
|
39 | if stage.len() > 0 && !stage.starts_with("s3://") && peer_type == DbType::Snowflake {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stage.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
nexus/analyzer/src/lib.rs
Outdated
| "cdc_staging_path", path_missing_err | ||
| ))); | ||
| } else if let Some(cdc_stage) = flow_job.cdc_staging_path.clone() { | ||
| let _ = stage_check(cdc_stage, destination_peer_type)?; |
There was a problem hiding this comment.
warning: this let-binding has unit value
--> analyzer/src/lib.rs:84:13
|
84 | let _ = stage_check(cdc_stage, destination_peer_type)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `stage_check(cdc_stage, destination_peer_type)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
Amogh-Bharadwaj
force-pushed
the
better-error
branch
from
16bb18f to
eb4d6f5
Compare
heavycrystal
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error messages for missing or incorrect values of
snapshot/cdc_sync_modeandsnapshot/cdc_staging_pathon the Nexus side.For ease of review, I've listed the error messages here:
Staging path for Snowflake must either be an S3 URL or an empty string for staging inside PeerDB.snapshot/cdc_staging_path missing or invalid for your destination peer(respectively)Tests have been added for these cases.