Eventhub fixes with Composite PKeys Support #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
eh-with-cpkeys
branch
from
e325739 to
d08460b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
flow/connectors/postgres/client.go
Outdated
| @@ -26,6 +27,8 @@ const ( | |||
| _peerdb_timestamp BIGINT NOT NULL,_peerdb_destination_table_name TEXT NOT NULL,_peerdb_data JSONB NOT NULL, | |||
| _peerdb_record_type INTEGER NOT NULL, _peerdb_match_data JSONB,_peerdb_batch_id INTEGER, | |||
| _peerdb_unchanged_toast_columns TEXT)` | |||
| createRawTableBatchIDIndexSQL = "CREATE INDEX IF NOT EXISTS %s_batchid_idx ON %s.%s(_peerdb_batch_id)" | |||
| createRawTableDstTableIndexSQL = "CREATE INDEX IF NOT EXISTS %s_dst_table_idx ON %s.%s(_peerdb_destination_table_name)" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 123 characters (lll)
flow/connectors/postgres/postgres.go
Outdated
| replicaIdentity, replicaIdentityErr := c.getReplicaIdentityForTable(schemaTable) | ||
| log.Infof("replica identity: %s", replicaIdentity) | ||
| if req.DestinationPeerType != protos.DBType_EVENTHUB || replicaIdentityErr != nil || replicaIdentity != "f" { | ||
| return nil, fmt.Errorf("error getting primary key column or replica identity for table %s: %w", schemaTable, err) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 125 characters (lll)
Amogh-Bharadwaj
added a commit
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Kevin Biju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.