support for mirror if not exists #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
mirror-if-not
branch
2 times, most recently
from
09f2069 to
ee31878
Compare
iskakaushik
requested changes
Sep 15, 2023
| @@ -199,79 +199,134 @@ impl NexusBackend { | |||
| "OK", None, | |||
| ))]) | |||
| } | |||
| PeerDDL::CreateMirrorForCDC { flow_job } => { | |||
| PeerDDL::CreateMirrorForCDC { | |||
There was a problem hiding this comment.
can we refactor handling this branch to its own function? It seems pretty complex now, can you refactor to make it readable.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nexus/server/src/main.rs
Outdated
| @@ -32,11 +32,11 @@ use pgwire::{ | |||
| tokio::process_socket, | |||
| }; | |||
| use pt::{ | |||
| flow_model::QRepFlowJob, | |||
| flow_model::{FlowJob, QRepFlowJob}, | |||
There was a problem hiding this comment.
warning: unused import: `FlowJob`
--> server/src/main.rs:35:18
|
35 | flow_model::{FlowJob, QRepFlowJob},
| ^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
71c7ce5 to
09fa9c6
Compare
| @@ -136,7 +138,10 @@ impl StatementAnalyzer for PeerDDLAnalyzer { | |||
| if_not_exists: *if_not_exists, | |||
| })) | |||
| } | |||
| Statement::CreateMirror { create_mirror } => { | |||
| Statement::CreateMirror { | |||
| if_not_exists, | |||
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
error[E0026]: variant `sqlparser::ast::Statement::CreateMirror` does not have a field named `if_not_exists`
--> analyzer/src/lib.rs:142:17
|
142 | if_not_exists,
| ^^^^^^^^^^^^^ variant `sqlparser::ast::Statement::CreateMirror` does not have this field
Amogh-Bharadwaj
force-pushed
the
mirror-if-not
branch
from
e5f7c73 to
b5a4bad
Compare
iskakaushik
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.