Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventhub features - timing, metrics #389

Closed
wants to merge 10 commits into from
Closed

Eventhub features - timing, metrics #389

wants to merge 10 commits into from

Conversation

Amogh-Bharadwaj
Copy link
Contributor

No description provided.

return nil, fmt.Errorf("error getting pkey column value: %w", err)
pkeyColsMerged := make([]string, 0)
for _, pkeyCol := range req.TableNameSchemaMapping[tableName].PrimaryKeyColumns {
pkeyColVal := rec.GetItems()[pkeyCol]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
invalid operation: cannot index rec.GetItems() (value of type *model.RecordItems)

tablePkeyVal := model.TableWithPkey{
TableName: tableName,
PkeyColVal: *pkeyColVal,
PkeyColVal: strings.Join(pkeyColsMerged, " "),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
cannot use strings.Join(pkeyColsMerged, " ") (value of type string) as qvalue.QValue value in struct literal

return nil, fmt.Errorf("error getting pkey column value: %w", err)
pkeyColsMerged := make([]string, 0)
for _, pkeyCol := range req.TableNameSchemaMapping[tableName].PrimaryKeyColumns {
pkeyColVal := rec.GetItems()[pkeyCol]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
invalid operation: cannot index rec.GetItems() (value of type *model.RecordItems)

}
tablePkeyVal := model.TableWithPkey{
TableName: tableName,
PkeyColVal: *pkeyColVal,
PkeyColVal: strings.Join(pkeyColsMerged, " "),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
cannot use strings.Join(pkeyColsMerged, " ") (value of type string) as qvalue.QValue value in struct literal) (typecheck)

return nil, fmt.Errorf("error getting pkey column value: %w", err)
pkeyColsMerged := make([]string, 0)
for _, pkeyCol := range req.TableNameSchemaMapping[tableName].PrimaryKeyColumns {
pkeyColVal := rec.GetItems()[pkeyCol]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
invalid operation: cannot index rec.GetItems() (value of type *model.RecordItems)

}
tablePkeyVal := model.TableWithPkey{
TableName: tableName,
PkeyColVal: *pkeyColVal,
PkeyColVal: strings.Join(pkeyColsMerged, " "),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
cannot use strings.Join(pkeyColsMerged, " ") (value of type string) as qvalue.QValue value in struct literal (typecheck)

return nil, fmt.Errorf("error getting pkey column value: %w", err)
pkeyColsMerged := make([]string, 0)
for _, pkeyCol := range req.TableNameSchemaMapping[tableName].PrimaryKeyColumns {
pkeyColVal := rec.GetItems()[pkeyCol]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
invalid operation: cannot index rec.GetItems() (value of type *model.RecordItems)

tablePkeyVal := model.TableWithPkey{
TableName: tableName,
PkeyColVal: *pkeyColVal,
PkeyColVal: strings.Join(pkeyColsMerged, " "),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
cannot use strings.Join(pkeyColsMerged, " ") (value of type string) as qvalue.QValue value in struct literal

return nil, fmt.Errorf("error getting pkey column value: %w", err)
pkeyColsMerged := make([]string, 0)
for _, pkeyCol := range req.TableNameSchemaMapping[tableName].PrimaryKeyColumns {
pkeyColVal := rec.GetItems()[pkeyCol]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
invalid operation: cannot index rec.GetItems() (value of type *model.RecordItems)

}
tablePkeyVal := model.TableWithPkey{
TableName: tableName,
PkeyColVal: *pkeyColVal,
PkeyColVal: strings.Join(pkeyColsMerged, " "),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
cannot use strings.Join(pkeyColsMerged, " ") (value of type string) as qvalue.QValue value in struct literal) (typecheck)

@serprex serprex deleted the eh-updates branch July 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants