[DRAFT] CDC mirrors with SCHEMA MAPPING support #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for _, table := range populateTableMappingFromSchemasOutput.TableMapping[srcSchema].Tables { | ||
| flowConnectionConfigs.TableNameMapping[fmt.Sprintf("%s.%s", srcSchema, table)] = | ||
| fmt.Sprintf("%s.%s", dstSchema, table) | ||
|
|
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unnecessary trailing newline (whitespace)
iskakaushik
requested changes
Sep 26, 2023
| @@ -127,6 +124,9 @@ message SetupReplicationInput { | |||
| bool do_initial_copy = 5; | |||
| string existing_publication_name = 6; | |||
| string existing_replication_slot_name = 7; | |||
|
|
|||
| // if length > 0, ignore table name mapping and use schemas as basis of publication creation | |||
There was a problem hiding this comment.
instead of this, can we pass the mapping type here?
flow/model/model.go
Outdated
| @@ -282,6 +284,8 @@ type SyncResponse struct { | |||
| TableSchemaDelta *protos.TableSchemaDelta | |||
| // to be stored in state for future PullFlows | |||
| RelationMessageMapping RelationMessageMapping | |||
| // to be used to create additional tables, for MappingType SCHEMA | |||
| AdditionalTableInfo *protos.AdditionalTableInfo | |||
There was a problem hiding this comment.
Can we push this info to TableSchemaDelta?
There was a problem hiding this comment.
refactored into an interface of various deltas
iskakaushik
reviewed
Sep 26, 2023
heavycrystal
force-pushed
the
schema-mapping-support
branch
from
6629834 to
7853885
Compare
|
|
||
| // if the functions are being called outside the context of a Temporal workflow, | ||
| // activity.RecordHeartbeat panics, this is a bandaid for that. | ||
| func (c *PostgresConnector) recordHeartbeatWithRecover(details ...interface{}) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
func (*PostgresConnector).recordHeartbeatWithRecover is unused (unused)
| @@ -478,7 +478,7 @@ func (c *SnowflakeConnector) SyncRecords(req *model.SyncRecordsRequest) (*model. | |||
| } | |||
|
|
|||
| func (c *SnowflakeConnector) syncRecordsViaSQL(req *model.SyncRecordsRequest, rawTableIdentifier string, | |||
| syncBatchID int64, syncRecordsTx *sql.Tx) (*model.SyncResponse, error) { | |||
| syncBatchID int64, syncRecordsTx *sql.Tx) (*protos.SyncResponse, error) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)
|
+1 this feature would have helped a customer we chatted with today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support only for Postgres and Snowflake for now