Create Peer APIs #445
Merged
Create Peer APIs #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
create-peer-apis
branch
from
991ddb6 to
bbe7c0c
Compare
iskakaushik
reviewed
Sep 28, 2023
protos/route.proto
Outdated
| } | ||
|
|
||
| enum ValidatePeerStatus { | ||
| VALID = 0; |
There was a problem hiding this comment.
For all enums add UNKNOWN as 0 and start from 1
flow/connectors/core.go
Outdated
| // case protos.DBType_SQLSERVER: | ||
| // return conneventhub.NewEventHubConnector(ctx, config.GetEventhubConfig()) | ||
| default: | ||
| return nil, ErrUnsupportedFunctionality |
There was a problem hiding this comment.
can you return a more detailed error with the info of the Peer and that it isn't supported?
flow/cmd/handler.go
Outdated
| config := req.Peer.Config | ||
| wrongConfigResponse := &protos.CreatePeerResponse{ | ||
| Status: protos.CreatePeerStatus_FAILED, | ||
| Message: "wrong config for connector", |
There was a problem hiding this comment.
more detailed response
flow/cmd/handler.go
Outdated
| peerType := req.Peer.Type | ||
| switch peerType { | ||
| case protos.DBType_POSTGRES: | ||
| pgConfig := config.(*protos.Peer_PostgresConfig).PostgresConfig |
There was a problem hiding this comment.
lets do pgConfig, ok and check if the cast is Ok, do this else where too
flow/cmd/handler.go
Outdated
| return wrongConfigResponse, nil | ||
| } | ||
| if encodingErr != nil { | ||
| log.Errorf("failed to encode peer config: %v", encodingErr) |
There was a problem hiding this comment.
for every error, add some info about the request that resulted in this response
iskakaushik
approved these changes
Sep 28, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
flow/cmd/handler.go
Outdated
| if err != nil { | ||
| return &protos.ValidatePeerResponse{ | ||
| Status: protos.ValidatePeerStatus_INVALID, | ||
| Message: fmt.Sprintf("peer type is missing or your requested configuration for %s peer %s was invalidated: %s", |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 123 characters (lll)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidatePeer and CreatePeer