Support EventHubGroup as an alias over multiple eventhub peers #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if err != nil { | ||
| return fmt.Errorf("failed to close eventhub client: %v", err) | ||
| log.Errorf("failed to close eventhub client: %v", err) | ||
| err = fmt.Errorf("failed to close eventhub client: %v", err) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
ineffectual assignment to err (ineffassign)
| if err != nil { | ||
| return fmt.Errorf("failed to close eventhub client: %v", err) | ||
| log.Errorf("failed to close eventhub client: %v", err) | ||
| err = fmt.Errorf("failed to close eventhub client: %v", err) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
ineffectual assignment to err (ineffassign)
Amogh-Bharadwaj
approved these changes
Sep 28, 2023
To support multiple subscriptions and namespaces we will allow a new peer type called EventHubGroup. ```sql CREATE PEER customer_1 FROM EVENTHUB WITH ( subscription_id = 'my-sub-id', resource_group = 'my-rg', namespace = 'my-ns', location = 'eastus' ); CREATE PEER customer_2 FROM EVENTHUB WITH ( ... ); CREATE PEER eventhub_group_1 FROM EVENTHUBGROUP WITH ( metadata_db = '...', customer_1 = true, customer_2 = true ) ``` After this change mirrors ought to be created with this event hub group peer. Fixes #441
iskakaushik
force-pushed
the
issue/441
branch
from
73e639d to
0ed16b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support multiple subscriptions and namespaces we will allow a new peer type called EventHubGroup.
After this change mirrors ought to be created with this event hub group peer.
Fixes #441