API Peer Validation for SQL Server #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
force-pushed
the
refactor-peer-validate
branch
from
a8f1f1f to
a2bd85d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nexus/server/src/main.rs
Outdated
| })) | ||
| })?; | ||
| if let PeerValidationResult::Invalid(validation_err) = validity { | ||
| return Err(PgWireError::UserError(Box::new(ErrorInfo::new( |
There was a problem hiding this comment.
warning: unneeded `return` statement
--> server/src/main.rs:242:17
|
242 | / return Err(PgWireError::UserError(Box::new(ErrorInfo::new(
243 | | "ERROR".to_owned(),
244 | | "internal_error".to_owned(),
245 | | format!("[peer]: invalid configuration: {}", validation_err),
246 | | )))
247 | | .into());
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
242 ~ Err(PgWireError::UserError(Box::new(ErrorInfo::new(
243 + "ERROR".to_owned(),
244 + "internal_error".to_owned(),
245 + format!("[peer]: invalid configuration: {}", validation_err),
246 + )))
247 ~ .into())
|
nexus/server/src/main.rs
Outdated
| ))) | ||
| .into()); | ||
| } else { | ||
| return Ok(()); |
There was a problem hiding this comment.
warning: unneeded `return` statement
--> server/src/main.rs:249:17
|
249 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
249 - return Ok(());
249 + Ok(())
|
nexus/server/src/main.rs
Outdated
| @@ -205,6 +204,53 @@ | |||
| } | |||
| } | |||
|
|
|||
| async fn validate_peer<'a>(&self, peer_type: i32, peer: &Peer) -> anyhow::Result<()> { | |||
| if peer_type != 6 { | |||
| let peer_executor = self.get_peer_executor(&peer).await.map_err(|err| { | |||
There was a problem hiding this comment.
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> server/src/main.rs:209:56
|
209 | let peer_executor = self.get_peer_executor(&peer).await.map_err(|err| {
| ^^^^^ help: change this to: `peer`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, uses the
ValidatePeergRPC endpoint for SQL Server on the Rust side. Tested for all relevant peers - SQL Server, PG, SF and BQ.Partially completes #484