Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Create Mirror #490

Merged
merged 9 commits into from
Oct 9, 2023
Merged

UI - Create Mirror #490

merged 9 commits into from
Oct 9, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

  • Implements Create Mirror user flow
  • Tested happy path by running a successful PG-SF mirror
  • Snapshot fields appear only when initial copy is toggled
  • Staging path fields appear only when sync mode is avro
  • Frontend validation tested

Fixes #432 and #433

github-actions[bot]
github-actions bot reviewed Oct 9, 2023
View reviewed changes
flow/cmd/handler.go Outdated
return id, peerType, nil
}

func schemaForTableIdentifier(tableIdentifier string, peerDbType int32) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
ST1003: func parameter peerDbType should be peerDBType (stylecheck)

@iskakaushik iskakaushik merged commit 1b0353c into main Oct 9, 2023
11 checks passed
@iskakaushik iskakaushik deleted the ui-create-mirror branch October 9, 2023 14:54
@iskakaushik iskakaushik mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating mirror between pg -> sf through UI
2 participants
@Amogh-Bharadwaj @iskakaushik