composite primary key support for SF, PG and BQ #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -26,6 +27,8 @@ const ( | |||
| _peerdb_timestamp BIGINT NOT NULL,_peerdb_destination_table_name TEXT NOT NULL,_peerdb_data JSONB NOT NULL, | |||
| _peerdb_record_type INTEGER NOT NULL, _peerdb_match_data JSONB,_peerdb_batch_id INTEGER, | |||
| _peerdb_unchanged_toast_columns TEXT)` | |||
| createRawTableBatchIDIndexSQL = "CREATE INDEX IF NOT EXISTS %s_batchid_idx ON %s.%s(_peerdb_batch_id)" | |||
| createRawTableDstTableIndexSQL = "CREATE INDEX IF NOT EXISTS %s_dst_table_idx ON %s.%s(_peerdb_destination_table_name)" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 123 characters (lll)
Amogh-Bharadwaj
force-pushed
the
composite-keys-v2
branch
from
03632a1 to
bc4ebc8
Compare
heavycrystal
force-pushed
the
composite-keys-v2
branch
from
ab33b8e to
4e91865
Compare
heavycrystal
changed the title
heavycrystal
changed the title
iskakaushik
reviewed
Oct 17, 2023
| src._peerdb_record_type=1 AND _peerdb_unchanged_toast_columns='%s' | ||
| THEN UPDATE SET %s `, quotedCols, ssep) | ||
| src._peerdb_record_type=1 AND _peerdb_unchanged_toast_columns='%s' | ||
| THEN UPDATE SET %s `, cols, ssep) |
There was a problem hiding this comment.
confirm that these are quoted
iskakaushik
approved these changes
Oct 17, 2023
This was referenced Oct 17, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues: #491 #492 #493 #494 #495
Supersedes: #129 and #164