Add gRPC method to get the status of a mirror #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
force-pushed
the
mirror-status
branch
from
e3641fd to
ad87da5
Compare
Amogh-Bharadwaj
approved these changes
Oct 12, 2023
|
|
||
| err = proto.Unmarshal(configBytes, &config) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Any reason why we don't want to return an error here like in the above function?
if err != nil {
return nil, fmt.Errorf("unable to unmarshal qrep config: %w", err)
}There was a problem hiding this comment.
in case where initial load is done for cdc we do not add the entry to flows table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.