Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code for int,timestamp partitioning using min,max values #555

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

heavycrystal
Copy link
Contributor

Only mechanism for partitioning will be num_rows_per_partition which is now a mandatory option. Unrecognized options in QRep mirror commands will now cause an error from the SQL interface layer.

@heavycrystal heavycrystal changed the title remove code for handling using min,max values for partitioning remove code for int,timestamp partitioning using min,max values Oct 23, 2023
@iskakaushik
Copy link
Contributor

@heavycrystal can you let the protos exist as is, but remove the usage of it?

@iskakaushik iskakaushik merged commit 909bbb1 into main Oct 23, 2023
12 checks passed
@serprex serprex deleted the eliminate-qrep-batch branch July 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants