Call WaitForNewRows at the end of each QRepWorkflow #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Oct 23, 2023
| @@ -257,11 +273,6 @@ func QRepFlowWorkflow( | |||
| maxParallelWorkers = int(config.MaxParallelWorkers) | |||
| } | |||
|
|
|||
| waitBetweenBatches := 5 * time.Second | |||
There was a problem hiding this comment.
even if there are new rows we might want to wait between batches, so please account for that.
There was a problem hiding this comment.
the function flowable.QRepWaitUntilNewRows is written such that atleast one sleep will occur before the function returns
|
for qrep can you make metadata schema default to public to make it match the current situation, else the existing mirrors will fail |
iskakaushik
approved these changes
Oct 23, 2023
heavycrystal
force-pushed
the
qrep-idle-leftovers
branch
from
8b3e31c to
d02873e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.