Better peer checks #572
Merged
Better peer checks #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
approved these changes
Oct 25, 2023
Amogh-Bharadwaj
force-pushed
the
better-peer-checks
branch
from
d04193f to
f780cfc
Compare
heavycrystal
requested changes
Dec 1, 2023
| @@ -141,8 +141,8 @@ func ValidCheck(s3Client *s3.S3, bucketURL string, metadataDB *metadataStore.Pos | |||
| } | |||
|
|
|||
| func (c *S3Connector) ConnectionActive() bool { | |||
| _, err := c.client.ListBuckets(nil) | |||
| return err == nil | |||
| _, listErr := c.client.ListBuckets(nil) | |||
There was a problem hiding this comment.
This doesn't seem like a strong enough check for the connection being active.
Something along the lines of the ValidCheck function seems better, the bucket seems to be constant anyway.
There was a problem hiding this comment.
The ValidCheck function is performed as part of validation
| async fn validate_peer<'a>(&self, peer: &Peer) -> anyhow::Result<()> { | ||
| //if flow handler does not exist, skip validation | ||
| if self.flow_handler.is_none() { | ||
| return Ok(()); |
There was a problem hiding this comment.
Should this always happen? A lot of our peer types are not usable from the query layer and having flow not validate them doesn't seem strong enough.
There was a problem hiding this comment.
Only Eventhub and Eventhub Group are not covered by our validation API
|
If Snowflake/BigQuery are using an external stage, |
iskakaushik
approved these changes
Dec 1, 2023
Amogh-Bharadwaj
force-pushed
the
better-peer-checks
branch
from
9051209 to
0c445bd
Compare
heavycrystal
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482
Fixes #484
Also checks for dataset existence for BQ Peer. (This will also be applicable to UI)