UI Peer Page - Stats and Slots #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amogh-Bharadwaj
commented
Oct 26, 2023
Amogh-Bharadwaj
commented
iskakaushik
reviewed
Oct 26, 2023
flow/cmd/peer_data.go
Outdated
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| func (h *FlowRequestHandler) GetPoolForPGPeer(ctx context.Context, peerName string) (*pgxpool.Pool, error) { |
There was a problem hiding this comment.
can this be a private method?
protos/route.proto
Outdated
| message StatInfo { | ||
| int64 pid = 1; | ||
| string query = 2; | ||
| float duration = 3; |
There was a problem hiding this comment.
wait_event, wait_event_type, query_start are extremely useful as well.
| } | ||
|
|
||
| message SlotInfo { | ||
| string slot_name = 1; |
There was a problem hiding this comment.
is there any additional data about when the slot was created?
protos/route.proto
Outdated
| @@ -94,6 +94,31 @@ message CDCSyncStatus { | |||
| google.protobuf.Timestamp end_time = 5; | |||
| } | |||
|
|
|||
| message PeerDataRequest { | |||
There was a problem hiding this comment.
lets call this PostgresPeerActivityInfoRequest
| return ( | ||
| <TableRow key={slotName}> | ||
| <TableCell> | ||
| {flowName.length >= 1 ? ( |
There was a problem hiding this comment.
refactor to its own component function const SlotMirrorInfo = .. { slotName, flowName?} or something along those lines.
| }); | ||
| return peerSlots.slotData; | ||
| }; | ||
| const getStatData = async () => { |
There was a problem hiding this comment.
sprinkle some new lines to make this more readable.
Amogh-Bharadwaj
force-pushed
the
ui-peer-page
branch
from
f9251f0 to
33bd6b9
Compare
Amogh-Bharadwaj
force-pushed
the
ui-peer-page
branch
from
33bd6b9 to
bc66f2b
Compare
iskakaushik
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.