Column Exclusion #601
Merged
Column Exclusion #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
exclude-columns
branch
3 times, most recently
from
80a25b1 to
aa72c90
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
iskakaushik
reviewed
Nov 6, 2023
serprex
force-pushed
the
exclude-columns
branch
5 times, most recently
from
f7a4072 to
834ea32
Compare
serprex
force-pushed
the
exclude-columns
branch
from
5800dc8 to
11f910d
Compare
serprex
commented
Nov 11, 2023
iskakaushik
approved these changes
Nov 11, 2023
iskakaushik
requested changes
Nov 11, 2023
serprex
force-pushed
the
exclude-columns
branch
from
e6607f7 to
543524c
Compare
|
Edgecase: with schema changes, drop excluded column. Expectation: ignore. Then add excluded column back. Expectation: continue excluding? |
Yes, continue excluding. Also currently mirrors are static, I think eventually we would want to make them dynamic, where a user can exclude more columns, but thats a problem for another day. |
serprex
force-pushed
the
exclude-columns
branch
from
ee04651 to
918f2ce
Compare
serprex
force-pushed
the
exclude-columns
branch
3 times, most recently
from
a052e93 to
94ab6f8
Compare
iskakaushik
approved these changes
Nov 17, 2023
Currently only extends things to handle exclude field from PeerDB-io/sqlparser-rs#21 but doesn't do anything with it
…s but maybe there's something to talk about here
… & had to rely on git checkout oldcommit to retrieve the old tree which thankfully had not been collected by git's gc yet
…ups. Now it works
setup_flow: copy tableSchema
serprex
force-pushed
the
exclude-columns
branch
from
538973d to
8ff216c
Compare
serprex
force-pushed
the
exclude-columns
branch
from
8ff216c to
4caf513
Compare
iskakaushik
pushed a commit
that referenced
this pull request
Nov 17, 2023
If a mirror is created with exclusions omit those columns from schema of target table Syntax is in `TABLE MAPPING` of `CREATE MIRROR`, `exclude:[col1,col2]` Ignores column appearing in schema changes too Fixes #428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mirror is created with exclusions omit those columns from schema of target table
Syntax is in
TABLE MAPPINGofCREATE MIRROR,exclude:[col1,col2]Ignores column appearing in schema changes too
Fixes #428