Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventhubs] Add more logs and retries #622

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

iskakaushik
Copy link
Contributor

No description provided.

@@ -203,10 +199,6 @@ func (c *EventHubConnector) SyncRecords(req *model.SyncRecordsRequest) (*model.S
shutdown <- true
}()

eventsPerBatch := int(req.PushBatchSize)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should PushBatchSize be marked deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, will do!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but only for eventhub

@iskakaushik iskakaushik force-pushed the eh-add-more-logs-and-retries branch from 5a7f8d7 to 1984f9f Compare November 7, 2023 15:38
@iskakaushik iskakaushik force-pushed the eh-add-more-logs-and-retries branch from 6a9cc99 to e98dbaf Compare November 7, 2023 15:47
@iskakaushik
Copy link
Contributor Author

landing for customer mirage

@iskakaushik iskakaushik merged commit 75519d9 into main Nov 7, 2023
9 checks passed
@serprex serprex deleted the eh-add-more-logs-and-retries branch July 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants