schema changes for QRep BigQuery #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Nov 9, 2023
serprex
reviewed
Nov 9, 2023
serprex
approved these changes
Nov 9, 2023
iskakaushik
force-pushed
the
qrep-schema-changes-bq
branch
from
7db266f to
e867700
Compare
iskakaushik
approved these changes
Nov 10, 2023
|
@heavycrystal why can there be an empty schema delta? |
|
currently there is no possibility for an empty SchemaDelta to be generated, but changed defensively |
|
closes #616 |
iskakaushik
force-pushed
the
qrep-schema-changes-bq
branch
from
e867700 to
d2b3837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a logic bug where the loop for processing SchemaDeltas would end processing early if an empty SchemaDelta was found.