Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QRep UI Improvements #645

Merged
merged 4 commits into from
Nov 11, 2023
Merged

QRep UI Improvements #645

merged 4 commits into from
Nov 11, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Nov 10, 2023 •
edited
Loading

  • Searchable dropdowns for table, watermark column, schema selection
  • Source peers in create mirror are only postgres peers
  • Fixes mirror status screen

Partially implements #646

serprex
serprex reviewed Nov 10, 2023
View reviewed changes
ui/package.json
@@ -49,6 +49,7 @@
"protobufjs": "^7.2.5",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-select": "^5.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary given existing dependency on @radix-ui/react-select ?

Copy link
Contributor Author

@Amogh-Bharadwaj Amogh-Bharadwaj Nov 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want our select dropdowns in create mirror (and everywhere else) to be searchable - a feature radix ui's react select does not seem to have.

I've issued #646 for this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate PR should be made making the switch, removing @radix-ui/react-select too

@serprex serprex self-requested a review November 10, 2023 23:25
@iskakaushik iskakaushik merged commit 173571e into main Nov 11, 2023
@serprex serprex mentioned this pull request Nov 11, 2023
Merged
serprex added a commit that referenced this pull request Nov 13, 2023
@serprex
Replace @radix-ui/react-select with react-select (#647)
83789cc 
app/peers/edit was placeholder code, so deleted it instead

Fixes #646

Effort began in #645 but fixes need to be merged quickly, so no time to
split out this PR & have a clean switch from one select component to the
other
@serprex serprex deleted the qrep-ui-improvements branch July 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex Awaiting requested review from serprex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik