peer-server: connect lazily #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running `dev-peerdb.sh` I saw peer-server failing due to grpc connection taking too long. Replace connect_with_retries with tonic's connect_lazy Also remove health check, if commandline includes grpc endpoint that endpoint should be used, regardless of health
serprex
commented
Nov 15, 2023
| @@ -349,24 +317,21 @@ impl FlowGrpcClient { | |||
| self.start_query_replication_flow(&cfg).await | |||
| } | |||
|
|
|||
| pub async fn is_healthy(&mut self) -> anyhow::Result<bool> { | |||
| pub async fn is_healthy(&mut self) -> bool { | |||
There was a problem hiding this comment.
Changed signature to bool since this function was always returning Ok(bool). This function is no longer used
|
verified by manually killing flow and restarting peerdb-server, all statements that don't need flow API work as expected. minor issue with misleading logs, this appears even if MIRROR commands are not enabled: |
|
Enabled/Disabled message is whether the argument was passed in. Maybe makes sense to remove logging that since it's just telling the user what command line arguments they passed in |
iskakaushik
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
dev-peerdb.shI saw peer-server failing due to grpc connection taking too long. Replace connect_with_retries with tonic's connect_lazyAlso remove health check, if commandline includes grpc endpoint that endpoint should be used, regardless of health
The underlying principle of this PR is that grpc server should be able to come up & down as it pleases & peer-server will use it when it's up (& ideally fail loudly but non-terminally while it's down). I'm not sure this PR achieves that principle tho