Mirror Overview UI #664
Merged
Mirror Overview UI #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
requested review from
pankaj-peerdb,
iskakaushik and
serprex
serprex
reviewed
Nov 15, 2023
serprex
reviewed
Nov 15, 2023
serprex
reviewed
Nov 15, 2023
serprex
reviewed
Nov 15, 2023
| const handleSort = useCallback( | ||
| (sortOption: 'startTime' | 'endTime' | 'numRows') => { | ||
| setDisplayedRows((currRows) => | ||
| [...currRows].sort((a, b) => { |
There was a problem hiding this comment.
Should sort be sorting allRows instead of current? Can see arguments for both
serprex
reviewed
Nov 15, 2023
serprex
reviewed
Nov 15, 2023
serprex
reviewed
Nov 15, 2023
Amogh-Bharadwaj
force-pushed
the
overview-ui
branch
2 times, most recently
from
4d6a6e4 to
a221863
Compare
serprex
reviewed
Nov 16, 2023
serprex
reviewed
Nov 16, 2023
Amogh-Bharadwaj
force-pushed
the
overview-ui
branch
from
a221863 to
fd6a396
Compare
Amogh-Bharadwaj
added a commit
that referenced
this pull request
Nov 16, 2023
Split from #664 --------- Co-authored-by: Philip Dubé <[email protected]>
Amogh-Bharadwaj
force-pushed
the
overview-ui
branch
from
fd6a396 to
95e149f
Compare
|
CDC and Snapshot tables in overview page now have sort, search and pagination logic in useMemo. Users can sort and search for an item across all rows irrespective of which page they're on. |
serprex
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654
Fixes #660
Fixes #656
/edit/[mirrorId])Start Time,End TimeandRows Synced. In Initial Load you can sort byStart TimeandTime per partition.View Morebutton click which pops up a modal with the info.