Wait for at least one record or PKM before returning even after timeout #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
Nov 16, 2023
serprex
reviewed
Nov 16, 2023
flow/connectors/utils/env.go
Outdated
| return val | ||
| } | ||
|
|
||
| func IsTestEnv() bool { |
There was a problem hiding this comment.
This is generally pretty dangerous unless used carefully. Since it means you aren't testing when !IsTestEnv & that's the case that matters
There was a problem hiding this comment.
100% agreed - filed: #672 and will follow-up with fixing the tests. The urgency in landing the PR is for a ongoing issue.
iskakaushik
force-pushed
the
wait-for-at-least-one
branch
9 times, most recently
from
de1d8c5 to
c6f0f1e
Compare
iskakaushik
force-pushed
the
wait-for-at-least-one
branch
from
c6f0f1e to
8274773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the flow was on connection timeout we would return the currently accumulated records. Now the
continueand resetting the standby deadline, means that we will continue waiting for newer records in case we don't have any records or PKMs.The reason we exit at all from
PullRecordsis to checkpoint. We store metadata on the destination corresponding to committed LSN and we do it in batches because data warehouses operate better that way. Without records there's no need to checkpoint and we can wait indefinitely.fixes: #670