test fixing with a side of BigQuery features #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -274,7 +274,7 @@ func (s *SnowflakeAvroSyncMethod) writeToAvroFile( | |||
| ) (int, string, error) { | |||
| var numRecords int | |||
| if s.config.StagingPath == "" { | |||
| ocfWriter := avro.NewPeerDBOCFWriterWithCompression(s.connector.ctx, stream, avroSchema) | |||
| ocfWriter := avro.NewPeerDBOCFWriter(s.connector.ctx, stream, avroSchema, avro.CompressZstd, qvalue.QDWHTypeSnowflake) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 126 characters (lll)
heavycrystal
force-pushed
the
unflake-test-pls
branch
from
28b155e to
97ef4d8
Compare
| @@ -274,7 +274,7 @@ func (s *SnowflakeAvroSyncMethod) writeToAvroFile( | |||
| ) (int, string, error) { | |||
| var numRecords int | |||
| if s.config.StagingPath == "" { | |||
| ocfWriter := avro.NewPeerDBOCFWriterWithCompression(s.connector.ctx, stream, avroSchema) | |||
| ocfWriter := avro.NewPeerDBOCFWriter(s.connector.ctx, stream, avroSchema, avro.CompressZstd, qvalue.QDWHTypeSnowflake) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 126 characters (lll)
heavycrystal
force-pushed
the
unflake-test-pls
branch
from
e681cef to
aa97878
Compare
heavycrystal
force-pushed
the
unflake-test-pls
branch
from
12149f6 to
a9b982f
Compare
iskakaushik
reviewed
Nov 22, 2023
| @@ -21,31 +21,32 @@ type QRecordBatch struct { | |||
| // Equals checks if two QRecordBatches are identical. | |||
| func (q *QRecordBatch) Equals(other *QRecordBatch) bool { | |||
| if other == nil { | |||
| fmt.Printf("other is nil") | |||
There was a problem hiding this comment.
remove some of these logs and revert the rest to log.Infof
There was a problem hiding this comment.
log.Infof doesn't show up in the logs sometimes when it fails
|
@heavycrystal flow tests ran in 1 minute which seems wrong |
Seems to be cached from when I rebased, previous run took 25+ mins |
iskakaushik
approved these changes
Nov 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have now been unparallelized, will parallelize later through a different mechanism.
BigQuery supports local staging, using it for all tests now for better cleanup.
Added option to compress via Snappy and Deflate along with some cleanup, doesn't work for BQ yet