Runs SendWalHeartbeat in parallel #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
requested changes
Nov 17, 2023
| @@ -268,6 +256,13 @@ func CDCFlowWorkflowWithConfig( | |||
| state.Progress = append(state.Progress, "executed setup flow and snapshot flow") | |||
| } | |||
|
|
|||
| heartbeatCancelCtx, cancelHeartbeat := workflow.WithCancel(ctx) | |||
| walHeartbeatCtx := workflow.WithActivityOptions(heartbeatCancelCtx, workflow.ActivityOptions{ | |||
There was a problem hiding this comment.
make start to close timeout much longer like 1 week
flow/workflows/cdc_flow.go
Outdated
| StartToCloseTimeout: 5 * time.Minute, | ||
| }) | ||
| workflow.ExecuteActivity(walHeartbeatCtx, flowable.SendWALHeartbeat, cfg) | ||
| //walHeartbeatFuture.Get(ctx, nil) |
flow/activities/flowable.go
Outdated
| err = srcConn.SendWALHeartbeat() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to send WAL heartbeat: %w", err) | ||
| ticker := time.NewTicker(10 * time.Second) |
There was a problem hiding this comment.
make it once every 10 mins and add a log with flow job name in it
iskakaushik
approved these changes
Nov 17, 2023
Amogh-Bharadwaj
force-pushed
the
walheartbeat-always
branch
from
6179b75 to
af2c67c
Compare
iskakaushik
force-pushed
the
walheartbeat-always
branch
from
af2c67c to
eed05ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendWalHeartbeat now runs every 10 seconds in parallel during the PeerFlow phase of CDC (after setup and snapshot)
cancelActivity is called where previously the .Get() on the activity was called in
cdc_flow.go