Use catalog as external store #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Nov 17, 2023
ui/components/S3Form.tsx
Outdated
| @@ -130,75 +113,6 @@ const S3ConfigForm = ({ setter }: S3Props) => { | |||
| /> | |||
| ); | |||
| })} | |||
|
|
|||
| <Label | |||
There was a problem hiding this comment.
This PR makes this optional, why is it removing it from UI?
There was a problem hiding this comment.
Yup good point. Restored the UI for metadata DB which is now toggled via a switch (Screenshot in PR)
Amogh-Bharadwaj
force-pushed
the
handle-metadatadb
branch
from
9732563 to
e7e1ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If metadataDB is set to empty string/undefined, we now use catalog as the metadata postgres instance for S3/GCS and Eventhub CDC