nexus cleanup #702
Merged
nexus cleanup #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
serprex
commented
Nov 22, 2023
•
serprex
commented
- fix typo: QueryAssocation to QueryAssociation
- remove unnecessary allocations for two-item keys_to_ignore
- make NexusQueryParser get_peers_bridge/parse_simple_sql async; all callers are async
- use with_capacity whenever straightforward to do so
- change peer-snowflake SQLStatement parameters to struct since it serializes to a constant object
1. fix typo: QueryAssocation to QueryAssociation 2. remove unnecessary allocations for two-item keys_to_ignore 3. make NexusQueryPArser get_peers_bridge/parse_simple_sql async; all callers are async
serprex
force-pushed
the
cleanup-unnecessary-hashset
branch
from
345c654 to
7ab8398
Compare
iskakaushik
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.