WalHeartBeat across peers #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Nov 24, 2023
flow/cmd/api.go
Outdated
| @@ -58,6 +62,27 @@ func setupGRPCGatewayServer(args *APIServerParams) (*http.Server, error) { | |||
| return server, nil | |||
| } | |||
|
|
|||
| func KillExistingHeartbeatFlows(ctx context.Context, tc client.Client, namespace string) error { | |||
There was a problem hiding this comment.
this can be private method
iskakaushik
reviewed
Nov 24, 2023
flow/activities/flowable.go
Outdated
| @@ -659,31 +663,79 @@ func (a *FlowableActivity) DropFlow(ctx context.Context, config *protos.Shutdown | |||
| return nil | |||
| } | |||
|
|
|||
| func (a *FlowableActivity) SendWALHeartbeat(ctx context.Context, config *protos.FlowConnectionConfigs) error { | |||
| srcConn, err := connectors.GetCDCPullConnector(ctx, config.Source) | |||
| func GetPostgresPeerConfigs(ctx context.Context) ([]*protos.PostgresConfig, error) { | |||
iskakaushik
reviewed
Nov 24, 2023
flow/activities/flowable.go
Outdated
| } | ||
| defer catalogPool.Close() | ||
|
|
||
| optionRows, err := catalogPool.Query(ctx, "SELECT options FROM peers WHERE type=3") |
There was a problem hiding this comment.
is there a way to get 3 from proto like proto.Postgres.Type or something?
iskakaushik
approved these changes
Nov 24, 2023
Amogh-Bharadwaj
force-pushed
the
walheartbeat-for-peers
branch
from
6656118 to
b1c4256
Compare
iskakaushik
approved these changes
Nov 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign WAL Heartbeat Logic
HeartbeatFlowWorkflow.Other: Fixes a typo in UI:
snapshow->snapshot