Migrate to Go 1.21's native slog #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Dec 6, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
serprex
approved these changes
Dec 6, 2023
|
What made you choose slog over zerolog/zap? Preference for stdlib? |
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
from
8af3f3b to
16caec6
Compare
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
from
533a96b to
a27dcc7
Compare
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
from
fe03c0b to
27b6351
Compare
serprex
reviewed
Dec 11, 2023
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
5 times, most recently
from
4468005 to
e8ea360
Compare
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
from
e2887b0 to
b44c116
Compare
Amogh-Bharadwaj
force-pushed
the
migrate-logs
branch
from
b44c116 to
ebe10d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
slogand gets rid oflogrus.flowName,deploymentUidand for the most partpartitionIdare now set at the top level function/workflow calls and are accessed by children for logs. They do not need to be specified when logging. The context values are read via logging middleware inlogger/handler.go.