qvalue: pass by value #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
qvalue-by-value
branch
from
3cd18a4 to
d61361e
Compare
serprex
commented
Dec 13, 2023
No benchmarks, but... |
iskakaushik
approved these changes
Dec 13, 2023
serprex
force-pushed
the
qvalue-by-value
branch
from
aece63a to
1bd918d
Compare
QValue is a string/interface{} pair
string is a pointer/int pair
interface{} is a pointer/pointer pair
Copying four words is cheap, especially when for the most part qvalues are stored in a QRecord which will itself be passed around by pointer
serprex
force-pushed
the
qvalue-by-value
branch
from
d57ae93 to
6398e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QValue is a string/interface{} pair
string is a pointer/int pair
interface{} is a pointer/pointer pair
Copying four words is cheap, especially when for the most part qvalues are stored in a QRecord which will itself be passed around by pointer
Include a
QValueKindEmptywhich is used in places where previously pointer would be nil