CDCRecordStream: replace mutex with atomics #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Dec 13, 2023
| } | ||
|
|
||
| func (r *CDCRecordStream) GetLastCheckpoint() (int64, error) { | ||
| r.checkpointMutex.Lock() | ||
| defer r.checkpointMutex.Unlock() | ||
|
|
||
| if !r.lastCheckpointSet { |
There was a problem hiding this comment.
lastCheckpointSet seems kind of funny since it gets written to by Close without synchronization & here seems to only be an assertion. Seems like this struct has a mode between collection/read which would be cleaner as a channel which gets sent first/last checkpoint id at end of pull or something (where we need to somehow communicate back to some process which has been storing a pointer to this from before pull began & is using some external sync to only read first/last after Close)
There was a problem hiding this comment.
I agree that channels to communicate most fields in this struct would be a good idea. I only wish channels had a GetOrWait primitive :-)
iskakaushik
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.