Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FirstCheckpointID #816

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Remove FirstCheckpointID #816

merged 1 commit into from
Dec 13, 2023

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Dec 13, 2023

This value is not currently being computed consistently, to be correct it should be taking the minimum checkpoint id, not the first

Ultimately it only serves for being written to monitoring, so remove it

This value is not currently being computed consistently,
to be correct it should be taking the minimum checkpoint id, not the first

Ultimately it only serves for being written to monitoring,
so remove it
@serprex serprex enabled auto-merge (squash) December 13, 2023 14:19
@serprex serprex merged commit 1f9c299 into main Dec 13, 2023
12 checks passed
@serprex serprex deleted the remove-first-checkpoint branch December 19, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants