nexus: reduce use of Arc where unnecessary #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
less-arc
branch
2 times, most recently
from
db05958 to
96a5c2a
Compare
Also have CatalogConfig borrow since args live for program's entire lifecycle get_executor now uses `entry` which isn't a clear win, as the API forces a clone on peer.name & takes a write lock, but now there's no race where two concurrent calls to get_executor create two separate connections A follow up would be to have Peer include id (maybe out of band, because protobufs), allowing many of these hashmaps to be keyed on id. That'd also avoid cache invalidation in the future if `ALTER PEER old RENAME TO new` were implemented Also properly escape string with single quote in `NexusBackend::parameter_to_string`
iskakaushik
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also have CatalogConfig borrow since args live for program's entire lifecycle
get_executor now uses
entrywhich isn't a clear win, as the API forces a clone on peer.name & takes a write lock, but now there's no race where two concurrent calls to get_executor create two separate connectionsA follow up would be to have Peer include id (maybe out of band, because protobufs), allowing many of these hashmaps to be keyed on id. That'd also avoid cache invalidation in the future if
ALTER PEER old RENAME TO newwere implementedAlso properly escape string with single quote in
NexusBackend::parameter_to_string