test enabling all golangci lints #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
golang-ci-enable-all
branch
from
aecc077 to
7c60d5b
Compare
Ignore tests for now
serprex
force-pushed
the
golang-ci-enable-all
branch
from
8ad207f to
221b907
Compare
serprex
force-pushed
the
golang-ci-enable-all
branch
from
11f51bf to
0ddb8ea
Compare
|
I learnt how to use golangci locally & enable-all seems like a bad idea based on these experiments, best to apply it piecemeal based on how much sense a linter makes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.