Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Improve table picker component #859

Merged
merged 2 commits into from
Dec 20, 2023
Merged

UI: Improve table picker component #859

merged 2 commits into from
Dec 20, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Dec 20, 2023 •
edited
Loading

  • Fixes SelectAll and SchemaExpand issues
  • Moves Column view to separate component for readability
  • Moves table picker below the settings for CDC and has more height
  • useMemo for table search
  • overall code improvements

serprex
serprex requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@serprex serprex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, otherwise lgtm

@iskakaushik iskakaushik merged commit d5baa48 into main Dec 20, 2023
10 checks passed
@iskakaushik iskakaushik deleted the ui/improvements-5 branch December 20, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik