Remove use of testify/suite #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
serprex
force-pushed
the
remove-testify-suite
branch
3 times, most recently
from
47a9538 to
8b43066
Compare
iskakaushik
approved these changes
Dec 22, 2023
serprex
force-pushed
the
remove-testify-suite
branch
from
4fd1636 to
b8a5020
Compare
Also run everything in parallel, randomizing suffixes as necessary
serprex
force-pushed
the
remove-testify-suite
branch
from
cc66857 to
1938976
Compare
serprex
force-pushed
the
remove-testify-suite
branch
from
b3f0253 to
3cf0e97
Compare
serprex
force-pushed
the
remove-testify-suite
branch
from
c823474 to
9212271
Compare
serprex
force-pushed
the
remove-testify-suite
branch
from
959fdbc to
a398110
Compare
serprex
added a commit
that referenced
this pull request
Dec 27, 2023
Splitting up changes from #871
serprex
added a commit
that referenced
this pull request
Dec 27, 2023
Splitting up changes from #871
serprex
added a commit
that referenced
this pull request
Dec 27, 2023
Splitting up changes from #871
serprex
added a commit
that referenced
this pull request
Dec 27, 2023
Splitting up changes from #871
serprex
added a commit
that referenced
this pull request
Dec 29, 2023
| s.NoError(err) | ||
| s.T().Log("Inserted initial row in the source table") | ||
| require.NoError(s.t, err) | ||
| s.t.Println("Inserted initial row in the source table") |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
s.t.Println undefined (type *testing.T has no field or method Println) (typecheck)
serprex
added a commit
that referenced
this pull request
Dec 30, 2023
Accidentally merged #871 (for some reason automerge triggered after merge with 0/6 CI steps complete)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also run everything in parallel, randomizing suffixes as necessary
e2esharedavoids cyclic dependencies