Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only initialize replication pool when needed in CDCPull #872

Merged
merged 3 commits into from
Dec 22, 2023
Merged

only initialize replication pool when needed in CDCPull #872

merged 3 commits into from
Dec 22, 2023

Conversation

heavycrystal
Copy link
Contributor

No description provided.

@iskakaushik iskakaushik merged commit 5d32604 into main Dec 22, 2023
7 checks passed
serprex added a commit that referenced this pull request Jan 1, 2024
@serprex
PostgresConnector replPool: initialize lazily
4bb43dc 
Alternative to #872

Allows #945 to test replPool code path without losing testing of codepaths without replPool
@serprex serprex mentioned this pull request Jan 1, 2024
Merged
serprex added a commit that referenced this pull request Jan 1, 2024
@serprex
PostgresConnector replPool: initialize lazily
9b56c85 
Alternative to #872

Allows #945 to test replPool code path without losing testing of codepaths without replPool
serprex added a commit that referenced this pull request Jan 1, 2024
@serprex
PostgresConnector replPool: initialize lazily
7261f6a 
Alternative to #872

Allows #945 to test replPool code path without losing testing of codepaths without replPool
serprex added a commit that referenced this pull request Jan 2, 2024
@serprex
PostgresConnector replPool: initialize lazily (#953)
837075e 
Alternative to #872

Allows #945 to test replPool code path without losing testing of codepaths without replPool

Can add a mutex in future if connectors should be threadsafe
@serprex serprex deleted the pgpeer-only-initialize-replpool-when-needed branch July 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@serprex serprex Awaiting requested review from serprex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heavycrystal @iskakaushik