Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing naming convention for getters in peerdbenv #875

Merged
merged 2 commits into from
Dec 22, 2023
Merged

changing naming convention for getters in peerdbenv #875

merged 2 commits into from
Dec 22, 2023

Conversation

heavycrystal
Copy link
Contributor

the Go convention is not to have Get in the function name, GetPeer vs Peer.

Can be changed in other places on a case by case basis.

@heavycrystal heavycrystal requested a review from serprex December 22, 2023 11:32
@iskakaushik iskakaushik merged commit 45a4205 into main Dec 22, 2023
6 checks passed
@serprex serprex deleted the peerdbenv-getter-naming-convention branch July 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@serprex serprex Awaiting requested review from serprex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heavycrystal @iskakaushik