Fix flow err log and cleanup flowable.go #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
approved these changes
Dec 22, 2023
|
@Amogh-Bharadwaj I think the tests might be failing because flow name param is null when inserting in catalog, can you check if context has flow name set in tests, if not can you set it? |
Amogh-Bharadwaj
force-pushed
the
better-flowable-flow-log
branch
from
9ac47d9 to
6ec47ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places we were logging peer names instead of flow name for the
peerdb_stats.flow_errorstable. Also some long lines have been split in this PR