Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it a non-fatal error if we are unable to get slot information #891

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Make it a non-fatal error if we are unable to get slot information #891

merged 1 commit into from
Dec 23, 2023

Conversation

iskakaushik
Copy link
Contributor

No description provided.

serprex
serprex approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@serprex serprex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is warning: needed when it's slog WarnContext?

@iskakaushik iskakaushik merged commit e20a2e5 into main Dec 23, 2023
7 checks passed
@serprex serprex deleted the non-fatal-slot-info-monitoring branch July 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskakaushik @serprex