Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unique constraint violation during CREATE IF NOT EXISTS #905

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Ignore unique constraint violation during CREATE IF NOT EXISTS #905

merged 2 commits into from
Dec 26, 2023

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Dec 26, 2023

@serprex
Copy link
Contributor Author

serprex commented Dec 26, 2023

We'll probably want to move isUniqueError to a utility package eventually, but not in a rush to do so

@serprex serprex enabled auto-merge (squash) December 26, 2023 19:15
@serprex serprex merged commit 2f18f76 into main Dec 26, 2023
7 checks passed
serprex added a commit that referenced this pull request Dec 30, 2023
@serprex
postgres connector: ignore unique constraint violations from IF NOT E…
f0a68cd 
…XISTS

Followup from #905 now that I've seen parallel testing of pg connector running into this
@serprex serprex mentioned this pull request Dec 30, 2023
Merged
serprex added a commit that referenced this pull request Dec 30, 2023
@serprex
postgres connector: ignore unique constraint violations from IF NOT E…
e185c82 
…XISTS

Followup from #905 now that I've seen parallel testing of pg connector running into this
serprex added a commit that referenced this pull request Dec 30, 2023
@serprex
postgres connector: ignore unique constraint violations from IF NOT E…
a182a23 
…XISTS (#942)

Followup from #905 now that I've seen parallel testing of pg connector (#941) running into this
@serprex serprex mentioned this pull request Dec 30, 2023
Merged
serprex added a commit that referenced this pull request Dec 31, 2023
@serprex
Don't create metadata schema in a transaction (#943)
c6e284e 
When a command errors during a transaction the transaction can no longer progress, it must be rolled back
This is the case when IF NOT EXISTS errors over unique violation

We do not need schema/table creation to be transactional, so remove transaction

Corrects #942 & #905 to be effective
@serprex serprex deleted the ignore-unique branch February 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amogh-Bharadwaj Amogh-Bharadwaj Amogh-Bharadwaj approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @Amogh-Bharadwaj