partial mixed case support for SF #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Dec 28, 2023
| @@ -296,10 +301,10 @@ func (c *SnowflakeConnector) getColsFromTable(tableName string) (*model.ColumnIn | |||
| } | |||
| defer rows.Close() | |||
|
|
|||
| var colName pgtype.Text | |||
There was a problem hiding this comment.
why were these moved outside the loop?
There was a problem hiding this comment.
I'd guess the goal is to avoid clearing an empty stack slot each loop, which may also be boxed depending how go analyzes Scan. This refactor has been appearing in a few previous PRs
|
Could use test cases demonstrating what now works. PR is pretty large so splitting refactoring to another PR would be nice, but lgtm |
serprex
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some edge cases, but should work for basic mixed case tables.
Will revisit this later, need to spend some time with cases.
Some outstanding issues:
COPYstatement generation."INFINITE") which is the default casing for Snowflake but the opposite for Postgres.