Fix alerts and logs #920
Merged
Fix alerts and logs #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amogh-Bharadwaj
commented
Dec 28, 2023
•
Amogh-Bharadwaj
commented
- Alerts Snapshot flow errors.
- Passes flow name to a few activity functions so we can use them for alerting and logging
- Noticed Temporal does not propagate context values of internal.Context to context.Context when going from Workflow -> Activity. So context values are now assigned starting from the activity level. In the future we could implement ContextPropagator but I feel it's not needed
heavycrystal
approved these changes
Dec 28, 2023
Amogh-Bharadwaj
force-pushed
the
fix-alerts-and-logs
branch
from
8ca421f to
6a679a3
Compare
iskakaushik
approved these changes
Dec 28, 2023
Amogh-Bharadwaj
force-pushed
the
fix-alerts-and-logs
branch
from
af6b64e to
0accb70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.